feat: delete-modal pin guidance, improved language

[jessicaschilling]

Summary

This PR prepares for pinning service continuity and improves overall UX of the Files screen "Delete" modal as follows:

• Replaces "delete" language with "remove" and clarifies re garbage collection and possible presence on other nodes
• Adds checkbox option for removing an item's local pin (if one exits)
• Adds checkbox option for unpinning from all pinning services
• Note: Doesn't add a checkbox for GC per concerns in 'Delete' modal: improve pin guidance and overall language  #1634 (comment)

Closes #1634.
Closes #1258

Done

• Update modal title, text, buttons for all variants (item, folder, file)
• Add (but don’t wire up) checkboxes
• Update context-menu item title
• Update multi-select menu item title
• Replace actions.delete with actions.remove in app.json; make sure this doesn’t cause any other issues
• Rename deleteModal/DeleteModal to removeModal/RemoveModal and update file names accordingly
• Replace “delete” with “remove” throughout, both in UI messaging and in codebase where it’s more apropos (NOTE: I veered on the side of conservative here, @lidel may have other ideas)
• Update modal styling per @ericronne suggestions (note: standardized modals on Files page for visual consistency, but didn’t go further since that’ll be covered in Standardize modal visual presentation #1643)
• Fixed unrelated file list refresh issues: close File listing does not refresh after file rename #996, close Files: Import from IPFS does not refresh file list #1740 and close Files: delete via bottom drawer does not close the drawer #1742

To do

• Wire up checkboxes (first box should be checked by default)
• Address "Delete folder" dialog does not show folder name #1258 while we're here by adding the name of the (file, folder) to be deleted if only one item is being deleted: Are you sure you want to remove "catphoto.gif"?

Open question

Should we change CLI tutor mode guidance in any way to match?

Screenshot

(Note this doesn't include the language Are you sure you want to remove "catphoto.gif"? - can update screenshot if desired)

[jessicaschilling]

@lidel -- this one is ready for you to wire up at your leisure 😊
Note: I've still got reservations about adding a GC checkbox ... see #1634 (comment)

[lidel]

Second option is blocked by #1615, I'd park this until we have pinning services wired up, then rebase this PR.

[lidel]

@rafaelramalho19 I won't have bandwidth for pushing this over finish line any time soon, mind taking it over?

[rafaelramalho19]

@jessicaschilling maybe the first checkbox should be selected by default?

[jessicaschilling]

@rafaelramalho19 Sounds good, please do!

[jessicaschilling]

Quick note: per discussion in #1258 (comment), please include the name of the (file, folder) to be deleted if only one item is being deleted. This would mean first line of text would be:

Are you sure you want to remove "catphoto.gif"?

@rafaelramalho19 happy to make up another screenshot if you want it, but this is pretty self-explanatory 😊

[jessicaschilling]

@rafaelramalho19 - I rebased this against current master, so this should be relatively easy to finish up (please see the first comment for checklist of remaining items to do). It's one of the remaining issues in the pinning service integration epic, so please prioritize with that work. Thank you!

[lidel]

@rafaelramalho19 mind rebasing this?

I believe we want to land this along with #1721

[lidel]

@rafaelramalho19 #1713 just got merged, this PR should be unblocked now for you to rebase and resume work.

I believe the behavior we want is:

• if file is pinned locally
  • show option to remove local pin, it should be checked by default
• if file is pinned remotely
  • show option to remove all remote pins, but it should be unchecked by default
• if file has no pins, we dont show those additional options
• do not trigger GC, its removed from the scope of this work (go-ipfs may get better GC in the future, we should wait for that)

[rafaelramalho19]

@lidel ready for review 🎉

[lidel]

@rafaelramalho19 Thank you, works as expected (found edge case but fixed it in 5285a8b) 👌

The only remaining ask is to replace checkboxes with styled ones that we already use on Files list:

[rafaelramalho19]

@lidel In the last commit I also fixed #1742

[lidel]

Thanks! Works as expected.

Made two cosmetic tweaks:

(1) moved item name to modal title, so it is harder to miss:

(2) added truncation rule to the title so long filenames don't break the modal:

@jessicaschilling mind taking a quick look if above changes are ok?

[jessicaschilling]

@lidel Great idea 😊 Do you mind adding the question mark on the other side of the truncation ... so it displays whether or not truncation happens?

[lidel]

Unfortunately i18next does not support ICU translations with both pluralizations AND embedded tags, and for truncating only the filename we would have to wrap it in a <span>.

To avoid this mess, I can move the question mark before filename, so we don't need any additional tags.

It would look like this:

@jessicaschilling would that be better or worse?

[jessicaschilling]

It's not visually pretty, but it's better semantically. Go for it. 😊