Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!feat: Remove ipld-git #347

Merged
merged 1 commit into from
Jan 16, 2023
Merged

!feat: Remove ipld-git #347

merged 1 commit into from
Jan 16, 2023

Conversation

whizzzkid
Copy link
Collaborator

@whizzzkid whizzzkid requested a review from a team as a code owner December 2, 2022 08:17
@welcome
Copy link

welcome bot commented Dec 2, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

SgtPooki
SgtPooki approved these changes Jan 11, 2023
View reviewed changes
src/bundles/explore.js
@@ -184,7 +184,6 @@ async function getIpld () {
import(/* webpackChunkName: "ipld" */ 'ipld'),
import(/* webpackChunkName: "ipld" */ '@ipld/dag-cbor'),
import(/* webpackChunkName: "ipld" */ '@ipld/dag-pb'),
import(/* webpackChunkName: "ipld" */ 'ipld-git'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what else would be using this, but it's possible CIDs using git encoding will break.

Copy link
Member

@lidel lidel Jan 22, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whizzzkid does baf4bcfg4ep767tjp5lxyanx5urpjjgx5q2volvy still work?
It is the second example on the landing page:

https://explore.ipld.io
https://explore.ipld.io/#/explore/baf4bcfg4ep767tjp5lxyanx5urpjjgx5q2volvy

If you want to remove support for GIT, replace this example with DAG-CBOR as suggested in #355 🙏

@SgtPooki SgtPooki changed the title feat: Remove ipld-git !feat: Remove ipld-git Jan 11, 2023
@whizzzkid whizzzkid changed the base branch from master to rc/4.x-deps-update January 16, 2023 21:03
@whizzzkid whizzzkid merged commit 0dfd717 into rc/4.x-deps-update Jan 16, 2023
@whizzzkid whizzzkid deleted the feat/remove-ipld-git branch January 16, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel left review comments

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency on ipld-git
3 participants
@whizzzkid @lidel @SgtPooki