WIP: feat/pubsub #471
WIP: feat/pubsub #471
Conversation
|
@haadcode having troubles with this PR, now that I added (manually) the missing test files, it is missing other modules. Could you fetch this branch and try to run yourself and see which files are missing? I'm getting it was just the original PR that was missing things and you have the code in your machine. UPDATE: Seems I managed to get the tests to run, it fails in the browser though. |
|
@haadcode also, can you make a PR to js-ipfsd-ctl with the changes you made? |
| // If we're already subscribed, return an error | ||
| if (subscriptions[topic]) { | ||
| return callback(new Error(`Already subscribed to '${topic}'`)) | ||
| } |
There was a problem hiding this comment.
If we have several subscriptions, we just need to feed the messages to all of them.
dignifiedquire
force-pushed
the
feat/floodsub
branch
from
95224c7
to
5198b96
Compare
| @@ -57,11 +57,13 @@ module.exports = (send) => { | |||
| } | |||
| }, | |||
| publish: promisify((topic, data, callback) => { | |||
| const buf = Buffer.isBuffer(data) ? data : new Buffer(data) | |||
| if (!Buffer.isBuffer(data)) { | |||
| return callback(new Error('data must be a Buffer')) | |||
| @@ -64,7 +64,7 @@ | |||
| "gulp": "^3.9.1", | |||
| "hapi": "^16.0.1", | |||
| "interface-ipfs-core": "^0.22.1", | |||
| "ipfsd-ctl": "^0.17.0", | |||
| "@haad/ipfsd-ctl": "^0.18.0-beta.5", | |||
There was a problem hiding this comment.
Needs to be updated
Add dagnode-stream to transform file results to DAGNode objects. Add stream-to-value to convert a response stream to a single value. Refactor request-api so that chunked JSON objects are not buffered anymore. This touches a bunch of the files pushing the transform function down to the individual commands.
dignifiedquire
force-pushed
the
feat/floodsub
branch
from
eb68ec3
to
dce5205
Compare
|
Closing in favor of #493 |
|
Remind me @dignifiedquire @diasdavid that we need to talk about strategy/process for releasing dev versions in the future and handling dependencies in a sane way. |
This PR will add complete go-ipfs Pubsub API.
Missing:
Dependencies: