-
Notifications
You must be signed in to change notification settings - Fork 20
Add extension support #5
Conversation
Can we make the 'extension' be transparent and have a type instead, as for 'ipld', and 'protobuf', from UX perspective, it will be easier to read that we want to read the block that is stored as protobuf or as ipld, rather than having to know the extension (which .data doesn't really mean anything). |
|
||
```JavaScript | ||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master nicpicker :P
Not sure I agree with that. If we go this route we have to encode the mapping of type to extension into the |
I understand, hopefully, we won't to change again though :). It does make an |
return this.type | ||
} | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice way to do it :)
Depends on:
cc @diasdavid