Add configurable extension support #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2016
Closed
| "test:node": "dignified-test node", | ||
| "test:browser": "dignified-test browser", | ||
| "build": "dignified-build", | ||
| "coverage": "istanbul cover --print both -- _mocha test/node.js", |
There was a problem hiding this comment.
Could you update this one to be dignified-coverage
|
Overall looks good. I see a lot of code changes that are more codestyle nittpicks than features, its ok. Just check if we still need the buffer loaders and good to be merged. |
|
@diasdavid done |
|
"go home circle-ci, you are drunk" |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #32
Needed for https://github.com/ipfs/js-ipfs-ipld
cc @diasdavid