This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: changes peer prop in return value from swarm.peers to be a PeerId #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
force-pushed
the
fix/swarm-peers-peer-to-peerId
branch
from
01dbac6
to
32ae31b
Compare
|
Mac OS still has some issues. But remaining CI shows it is good. |
daviddias
approved these changes
Mar 16, 2018
|
With this merge, now the next release needs to be a minor |
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent with go-ipfs. See discussion here in #1248
depends on ipfs-inactive/interface-js-ipfs-core#230
fixes #1248