This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: remove ipld formats re-export #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vmx
force-pushed
the
remove-ipld-formats-re-export
branch
from
9a6a446
to
693c0ce
Compare
|
Those three commits should be merged together: |
This was referenced Oct 9, 2018
vmx
force-pushed
the
remove-ipld-formats-re-export
branch
from
693c0ce
to
cfc9fa6
Compare
Prior to this change the `ipld-dag-cbor` and `ipld-dag-pb` modules are re-exported so that can be accessed within the Browser bundle. Those modules normally don't need to be used directly, they are kind of implementation details of IPLD. Hence remove them. Now `ipld-dag-cbor` isn't a direct dependency of `jsipfs` anymore. BREAKING CHANGE: remove `types.dagCBOR` and `dag.dagPB` from public API If you need the `ipld-dag-cbor` or `ipld-dag-pb` module in the Browser, you need to bundle them yourself.
vmx
force-pushed
the
remove-ipld-formats-re-export
branch
from
cfc9fa6
to
9d12edc
Compare
|
Ci is finally green! :) |
|
Merging this as only fail is a CI issue: |
This was referenced Oct 29, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this caange the
ipld-dag-cborandipld-dag-pbmodulesare re-exported so that can be accessed within the Browser bundle.
Those modules normally don't need to be used directly, they are
kind of implementation details of IPLD. Hence remove them.
Now
ipld-dag-cborisn't a direct dependency ofjsipfsanymore.BREAKING CHANGE: remove
types.dagCBORanddag.dagPBfrom public API