This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: make ipfs.libp2p the libp2p node rather than component #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! The windows test failure is unrelated. I'll review this asap. Thanks again. |
alanshaw
changed the title
ghost
added
the
alanshaw
changed the title
…he way for the node (#1664) License: MIT Signed-off-by: Alex North <alex@alexnorth.me>
License: MIT Signed-off-by: Alex North <alex@alexnorth.me>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
I've pushed a refactor that means we don't have |
alanshaw
approved these changes
Jan 23, 2019
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt on #1664–see discussion there. It may not be complete as I had trouble running unit tests (at master). I am posting this by way of abandoning it and welcome someone taking it over to finish it off.
I'm not sure this is 100% the right approach; in particular the
this.libp2p = undefinedincore/index.jsis different to surrounding code. I don't know the project well enough to suggest an improvement here.resolves #1664