-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ipfs.libp2p should be the ipfs._libp2pNode #1664
Comments
I looked at this as an easy first change, but was thrown by the existing assignment to Line 150 in d215502
Is this explicitly requesting to move the component reference out of the way to a different key and punch through to this internal node reference? js-ipfs/src/core/components/libp2p.js Line 72 in d215502
|
@anorth exactly! Would you like to make that contribution? Thanks in advance :) |
@anorth what's the status on this? I see you've made some progress. Do you have the time to bring it over the line? 😜 If not then it would be ideal if you could submit a PR that someone else can finish off. |
Sorry I didn't bring it home–I switched away after struggling with tests. I look forward to finding some other low-hanging changes as I get to know the project. |
It is confusing for users that libp2p is not available through the .libp2p key and instead it is on ipfs._libp2pNode. Anyone opposed to this change?
The text was updated successfully, but these errors were encountered: