Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

ipfs.libp2p should be the ipfs._libp2pNode #1664

Closed
daviddias opened this issue Oct 24, 2018 · 4 comments · Fixed by #1832
Closed

ipfs.libp2p should be the ipfs._libp2pNode #1664

daviddias opened this issue Oct 24, 2018 · 4 comments · Fixed by #1832
Labels
exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now

Comments

@daviddias
Copy link
Member

It is confusing for users that libp2p is not available through the .libp2p key and instead it is on ipfs._libp2pNode. Anyone opposed to this change?

@alanshaw alanshaw added exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P3 Low: Not priority right now labels Oct 24, 2018
@alanshaw alanshaw mentioned this issue Nov 5, 2018
@anorth
Copy link
Member

anorth commented Dec 4, 2018

I looked at this as an easy first change, but was thrown by the existing assignment to .libp2p:

this.libp2p = components.libp2p(this)

Is this explicitly requesting to move the component reference out of the way to a different key and punch through to this internal node reference?

self._libp2pNode = libp2pBundle({

@daviddias
Copy link
Member Author

@anorth exactly! Would you like to make that contribution? Thanks in advance :)

@alanshaw
Copy link
Member

@anorth what's the status on this? I see you've made some progress. Do you have the time to bring it over the line? 😜

If not then it would be ideal if you could submit a PR that someone else can finish off.

@anorth
Copy link
Member

anorth commented Jan 18, 2019

Sorry I didn't bring it home–I switched away after struggling with tests. I look forward to finding some other low-hanging changes as I get to know the project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants