This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
WIP: Make http-api endpoints as specified by the http-api-spec, for the features present in core #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
|
|
||
| it('get the version', (done) => { | ||
| ctl.version((err, result) => { |
There was a problem hiding this comment.
@dignifiedquire I'm hitting an issue here that I would love to have your review. I implemented the http-api endpoint following the spec and you can see the test above (line 17) that it is indeed callable and returns the data as expected, however, the problem is that this js-ipfs-api call is giving me the result as a 'buffer', instead of the object correctly parsed, my first intuition was it was lacking headers, but I confirmed that I was adding the same headers as go-ipfs and still I got nothing. Any ideas? Thank you.
There was a problem hiding this comment.
@diasdavid there is your fix :) ipfs-inactive/js-ipfs-http-client#215
There was a problem hiding this comment.
sweeeet! :D Thank you @dignifiedquire :D
daviddias
force-pushed
the
feature/http-api
branch
from
3767b15
to
37f91f1
Compare
daviddias
force-pushed
the
feature/http-api
branch
2 times, most recently
from
7350c0a
to
101b833
Compare
daviddias
force-pushed
the
feature/http-api
branch
from
101b833
to
d169279
Compare
daviddias
added a commit
that referenced
this pull request
Feb 23, 2016
WIP: Make http-api endpoints as specified by the http-api-spec, for the features present in core
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
IPFS is all `dag-pb` yet we allow passing `dag-cbor` as the format of IPLD node to use. This is likely to break anything that uses it as tools expect IPFS stuff to be `dag-pb`, possibly with `raw` leaves. Closes ipfs#67 BREAKING CHANGE: `--format` and/or `--codec` option has been removed from the CLI, the HTTP API and the core API.
This was referenced May 25, 2021
This was referenced Jul 31, 2021
vasco-santos
pushed a commit
that referenced
this pull request
Sep 21, 2021
Bumps [uint8arrays](https://github.com/achingbrain/uint8arrays) from 1.1.0 to 2.0.5. - [Release notes](https://github.com/achingbrain/uint8arrays/releases) - [Changelog](https://github.com/achingbrain/uint8arrays/blob/master/CHANGELOG.md) - [Commits](achingbrain/uint8arrays@v1.1.0...v2.0.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR, still a WIP, it includes: