This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix #952 : adding +50Mb files via createAddStream #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although the solution should be really figuring out what is causing the mem leak, this sounds like a good interim solution. @pgte it seems that files.add is somehow doing a memleak |
daviddias
approved these changes
Sep 3, 2017
|
@diasdavid 👍 , Thanks. Yes this require alot more work to figure out the issue, but for use in an example it's important to keep code that doesn't crash. I think we should keep the issue open till we nail the main cause of the mem leak. |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
Also adjust Travis CI config to perform builds and tests with node 8. `npm install`, `npm run build`, and `npm run test` all succeeded locally with node version `8.3.0`. The reason for version `8.3.0` instead of `8.0.0` is that `8.3.0` introduced support for object rest/spread, which is used by at least one of this package's devDependencies (`go-ipfs-dep`). It may be the case that at runtime older versions of node would work correctly with the built package, but it seems simpler to settle on the minimum supported version being a version that can build, test, and use the package. Closes ipfs#983.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey , this is a fix for issue #952
This uses
createAddStreaminstead of add to add a fairly large file in the browser without crashing.