Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass ipfs config show errors #722

Merged
merged 4 commits into from
Oct 19, 2022
Merged

fix: pass ipfs config show errors #722

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
574c092
fix: pass ipfs config show errors
lidel Mar 14, 2022
f1f5bf8
fix: resolve type errors in ipfsd-daemon
SgtPooki Sep 13, 2022
a278d5e
Merge branch 'master' into fix/pass-config-show-errors
SgtPooki Sep 13, 2022
aba229e
Merge branch 'master' into fix/pass-config-show-errors
SgtPooki Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/ipfsd-daemon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,8 @@ class Daemon {
*/
async _getConfig (key = 'show') {
const {
stdout
stdout,
stderr
} = await execa(
this.exec,
['config', key],
Expand All @@ -363,7 +364,12 @@ class Daemon {
.catch(translateError)

if (key === 'show') {
return JSON.parse(stdout)
try {
return JSON.parse(stdout)
} catch (err) {
SgtPooki marked this conversation as resolved.
Show resolved Hide resolved
err.message = `${err.message}: ${stderr || stdout}`
throw err
}
}

return stdout.trim()
Expand Down