This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Add testing support for ipfs-cluster #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support custom selector (rather than hardcode go-ipfs-stress) * Fix panics when outputs does not have as many lines as expected * Fix env being provided unquoted and thus injecting bash commands * Fix env matching with ShouldBeEqual where match could happen if the variable name is just part of the output
|
I'm comfortable with all of these changes, any thoughts from your end @victorbjelkholm? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimal necessary to allow me to write and run some tests for cluster
I have run some of the original ipfs tests and they look good (meaning I haven't broken stuff with the changes).