Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs resolve should respect CID base #5234

Closed
ghost opened this issue Jul 15, 2018 · 3 comments · Fixed by #5789
Closed

ipfs resolve should respect CID base #5234

ghost opened this issue Jul 15, 2018 · 3 comments · Fixed by #5789
Assignees
@kevina
Labels
kind/bug A bug in existing code (including security flaws) topic/cidv1b32 Topic cidv1b32

Comments

@ghost
Copy link

ghost commented Jul 15, 2018

Version information: 0.4.16

Type: bug

Description:

Actual:

# ipfs resolve /ipfs/bafkreickb4yq3sr3q2xqn3z3wzimilsa4wkbx25azqbvcnihq65moyjcvi
/ipfs/zb2rhbdNoGAYtRfZgcobnk5bJWTrqZY18zZ2o3dmp4QD12mxV

Expected:

# ipfs resolve /ipfs/bafkreickb4yq3sr3q2xqn3z3wzimilsa4wkbx25azqbvcnihq65moyjcvi
/ipfs/bafkreickb4yq3sr3q2xqn3z3wzimilsa4wkbx25azqbvcnihq65moyjcvi

It forgets the base32 encoding and applies base58btc instead.

Part of ipfs/ipfs#337 (cc @kyledrake)
@ghost ghost added kind/bug A bug in existing code (including security flaws) topic/cidv1b32 Topic cidv1b32 labels Jul 15, 2018
@kevina kevina self-assigned this Jul 15, 2018
@Stebalien
Copy link
Member

This is going to be so painful...

@lidel lidel mentioned this issue Jul 27, 2018
Closed
@kevina kevina mentioned this issue Aug 4, 2018
Closed
@kevina
Copy link
Contributor

kevina commented Aug 4, 2018

This ended up being fairly easy to do #5289 now respects the CID in ipfs resolve.

@kevina
Copy link
Contributor

kevina commented Aug 4, 2018

However, other similar cases such of ipfs pin are not so easy. As a solution to that I present ipfs/go-cid#64.

This was referenced Aug 7, 2018
Closed
Open
@kevina kevina mentioned this issue Sep 17, 2018
Closed
@kevina kevina mentioned this issue Sep 28, 2018
Closed
This was referenced Nov 24, 2018
Closed
Merged
@hsanjuan hsanjuan reopened this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevina kevina

Labels
kind/bug A bug in existing code (including security flaws) topic/cidv1b32 Topic cidv1b32
Projects
None yet
Milestone
No milestone
3 participants
@Stebalien @hsanjuan @kevina