Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go-libp2p-kad-dht to v0.25.0 #10086

Closed
wants to merge 1 commit into from

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 18, 2023

This code includes the address filtering code required to work nicely with libp2p's smart dialler.

This code includes the address filtering code required to work nicely with libp2p's smart dialler.
@Jorropo Jorropo added the skip/changelog This change does NOT require a changelog entry label Aug 18, 2023
@Jorropo Jorropo requested a review from a team as a code owner August 18, 2023 11:21
@Jorropo Jorropo mentioned this pull request Aug 18, 2023
5 tasks
@hacdias
Copy link
Member

hacdias commented Aug 21, 2023

@Jorropo tests still seem to be failing

@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 21, 2023

I know, this somehow turned into a multi thousand lines refactor and fixing other bugs in the process.
I'll push once this builds.

@hacdias hacdias marked this pull request as draft August 21, 2023 08:13
@BigLep
Copy link
Contributor

BigLep commented Aug 24, 2023

In order to merge this we need to get CI green (of course) which involves fixing the underlying deadlock that is now manifesting.

@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 25, 2023

See #10100

@Jorropo Jorropo closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants