Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-libp2p-kad-dht #10100

Closed
wants to merge 6 commits into from
Closed

chore: update go-libp2p-kad-dht #10100

wants to merge 6 commits into from

Conversation

@Jorropo Jorropo added the skip/changelog This change does NOT require a changelog entry label Aug 25, 2023
@Jorropo Jorropo requested a review from a team as a code owner August 25, 2023 08:38
@dennis-tra
Copy link
Contributor

I this PR superseded by #10116?

@BigLep
Copy link
Contributor

BigLep commented Nov 9, 2023

2023-11-09 maintainer conversation:

  • High level: we either need to be able to update or we revert the breaking changes in go-libp2p-kad-dht
  • We can't test WAN mode in the CI tests.
  • Going to make test setup / configuration to see if can get tests to pass.
  • Need to backlog the "better way" of handling. @Jorropo will write this.

@BigLep
Copy link
Contributor

BigLep commented Jan 4, 2024

2024-01-04 maintainer conversation:

  • We don't know why 0.25 broke. We need to start here. Once we understand (and document) this, we will then figure out how we respond. (Getting understanding is the minimum requirement for 202401 Mercury).

@guillaumemichel
Copy link

go-libp2p-kad-dht v0.25.2 shouldn't be broken. However v0.25.0 introduced a change to prevent private addresses to land on the public Amino DHT, so some tests may need to be modified.

The following fix can be applied to tests failing because test nodes are using loopback/private addresses libp2p/go-libp2p-kad-dht#839 (comment)

Reference: https://github.com/libp2p/go-libp2p-kad-dht/blob/088322b3bd36f384963225348a23f5723a2b80c3/dual/dual.go#L98-L127

@lidel lidel closed this in #10378 Apr 4, 2024
@hacdias hacdias deleted the go-libp2p-kad-dht branch April 4, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

5 participants