Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.4.20 #6223

Merged
merged 6 commits into from
Apr 16, 2019
Merged

release 0.4.20 #6223

merged 6 commits into from
Apr 16, 2019

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Apr 16, 2019

This has been running on the gateways for several days. There are still a few issues unresolved but it looks good enough to ship.

closes #6223

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Apr 16, 2019
@ghost ghost added the status/in-progress In progress label Apr 16, 2019
@Stebalien
Copy link
Member Author

cc @ipfs/go-team

CHANGELOG.md Outdated Show resolved Hide resolved
to an _arbitrary_ peer as DNS is not secure (by default). Please do not rely on
this except for testing or unless you know what you're doing.

Finally, `ipfs swarm connect` now returns _all_ errors on failure. This should
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a change to the HTTP API that I'll need to account for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is just a behavior tweak. Ideally, we'll improve the connection manager later so it won't be necessary.


#### Changed: `ipfs files flush`

The `ipfs files flush` command now returns the CID of the flushed file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we did this to improve the CoreAPI. IIRC, my end goal was to avoid exposing any CIDs to the user until they explicitly call Flush so we can make the actual IPFS import part lazy.


The `ipfs swarm connect` command has a few new features:

It now marks the newly created connection as "important". This should ensure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be looking at adding tagging support in js this quarter for connection management, so this is something we should be able to look at adding in q3.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I noted above, this shouldn't really be necessary. However, we're still killing useful connections so this change makes the issue slightly less annoying.

CHANGELOG.md Outdated
#### Relays

After AutoRelay was introduced in go-ipfs 0.4.19, the number of peers connecting
through relays ski-rocketed to over 120K concurrent peers. This highlighted some
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sky, not ski!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emoji opportunity: 🎿-rocketed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️... too much skiing.

CHANGELOG.md Outdated
rapidly forming new connections. This will actually help _all_ nodes but will
especially help relays.

If you've enabled relays in go-ipfs 0.4.19 and it hasn't burned down your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably : "if you've enabled relay hop".

CHANGELOG.md Outdated
the docker container:

```bash
> docker run ipfs/go-ipfs config profile apply server # apply the server profile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some users not familiar with Docker may just copy&paste commands and get surprised that container started by the second command does not include changes applied by the first one.

A safer example would be to use the same container in both, e.g:

$ docker run --name my-container ipfs/go-ipfs:v0.4.20 config profile apply server # apply the server profile
$ docker start my-container # start the daemon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone not familiar with docker, thanks...

CHANGELOG.md Outdated
#### Relays

After AutoRelay was introduced in go-ipfs 0.4.19, the number of peers connecting
through relays ski-rocketed to over 120K concurrent peers. This highlighted some
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emoji opportunity: 🎿-rocketed

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
(per @lidel's CR)

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
alanshaw and others added 2 commits April 16, 2019 09:16
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Copy link
Contributor

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my Bitswap work

@Stebalien Stebalien merged commit 8efc825 into master Apr 16, 2019
@ghost ghost removed status/in-progress In progress labels Apr 16, 2019
@Stebalien
Copy link
Member Author

Good enough for me. We can always edit the release notes after the fact and I want this out the door.

@Stebalien Stebalien deleted the feat/release-0.4.20 branch April 16, 2019 17:47
forget to send out this record, even if it was offline when the content was
initially added. NOTE: go-ipfs _does_ continuously _re_-send provider records in
the background twice a day, it just might be a while before it gets around to
sending one out any specific one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo (very minor): I think this should be something like "...before it gets around to sending any specific one"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(could you file a PR to fix this)

@michaelavila michaelavila self-requested a review April 16, 2019 18:26
@michaelavila
Copy link
Contributor

LGTM wrt Content Routing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants