Expose additional migration APIs #8153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
force-pushed
the
chore/expose-migration-api
branch
from
93f092e
to
d63061d
Compare
hsanjuan
reviewed
Jun 15, 2021
|
@hsanjuan This PR is really just moving things around, to make them accessible for doing things like #7658. I have added a comment in the code to offer an explanation for the confusing construct you pointed out, but if you have any suggestions about a better way to do this (given the explanation) I would love to improve that code. |
Expose migration APIs for reading migration config and creating migration fetchers. This allows implementation of commands and external applications that want to retrieve migrations according to the Migration portion of the IPFS config. This change also moves some functionality that is specific to fetching migrations via IPFS into the `ipfsfetcher` package.
gammazero
force-pushed
the
chore/expose-migration-api
branch
from
5e05ba6
to
1ca7b76
Compare
|
bump |
masih
approved these changes
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose migration APIs for reading migration config and creating migration fetchers. This allows the implementation of commands and external applications that want to retrieve migrations according to the Migration portion of the IPFS config.
This change also moves some functionality that is specific to fetching migrations via IPFS into the
ipfsfetcherpackage.This PR is also a prerequisite for expanding the functionality of #7658