fix(node/libp2p): disable rcmg checkImplicitDefaults #8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
force-pushed
the
schomatis/fix/disable-rcmg-checks
branch
from
2d972ba
to
245e7da
Compare
lidel
approved these changes
May 12, 2022
| @@ -32,6 +32,7 @@ default_environment: &default_environment | |||
| CIRCLE_TEST_REPORTS: /tmp/circleci-test-results | |||
| CIRCLE_ARTIFACTS: /tmp/circleci-artifacts | |||
| GIT_PAGER: cat | |||
| IPFS_CHECK_RCMGR_DEFAULTS: 1 | |||
There was a problem hiding this comment.
Added this so we keep running old runtime checker on our CI until #8954 is fully baked.
lidel
force-pushed
the
schomatis/fix/disable-rcmg-checks
branch
from
dc58dc7
to
28a71e8
Compare
3 tasks
Closed
3 tasks
lidel
added a commit
to ipfs/ipfs-desktop
that referenced
this pull request
Jun 6, 2022
e2e was failing because of runtime resource manager checks we disabled since -rc1: ipfs/kubo#8965
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
fix(node/libp2p): disable rcmgr checkImplicitDefaults
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
fix(node/libp2p): disable rcmgr checkImplicitDefaults (cherry picked from commit e23a461)
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
fix(node/libp2p): disable rcmgr checkImplicitDefaults (cherry picked from commit e23a461)
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
fix(node/libp2p): disable rcmgr checkImplicitDefaults (cherry picked from commit e23a461)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick band-aid for #8949 to fix master before #8954 lands.