fix(cmd): useful errors in dag import #9945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the time the error is either a bitflip in one of blocks, or a truncation of car stream. This allows user to understand what happened and at which place in the car stream, making debug more humane.
this also correctly exits CLI commands with code 1 (was silent false-positive 0 before)
lidel
force-pushed
the
fix/useful-error-on-dag-import
branch
from
46d9c8e
to
4bcfe07
Compare
This was referenced Jun 13, 2023
|
seems reasonable, this kind of UX might be nice in some of the go-car standalone cli commands |
|
Ok, merging, as I want to add more tests in #9926 and this will be useful. |
Closed
hacdias
pushed a commit
that referenced
this pull request
Jun 15, 2023
* fix: useful errors during dag import Most of the time the error is either a bitflip in one of blocks, or a truncation of car stream. This allows user to understand what happened and at which place in the car stream, making debug more humane. * fix: correct message when root pin failed this also correctly exits CLI commands with code 1 (was silent false-positive 0 before)
hacdias
pushed a commit
that referenced
this pull request
Jun 15, 2023
* fix: useful errors during dag import Most of the time the error is either a bitflip in one of blocks, or a truncation of car stream. This allows user to understand what happened and at which place in the car stream, making debug more humane. * fix: correct message when root pin failed this also correctly exits CLI commands with code 1 (was silent false-positive 0 before)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve UX of importing broken (truncated) CARs.
Most of the time, the error during
ipfs dag importis caused by either a bitflip in one of the blocks, or a truncation of the car stream. This PR improves returned error with context that allows the user to understand what happened, and at which place in the car stream, making debug more humane:Also, improved pin error on partial CAR import:
$ curl -v 'http://127.0.0.1:8080/ipns/docs.ipfs.tech?format=car&dag-scope=entity' > ./partial-entity.car # Kubo 0.21.0-rc1 with IPIP-402Before:
After: