Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPIP-410: Streaming Routing V1 HTTP API #410

Merged
merged 2 commits into from Jun 15, 2023
Merged

IPIP-410: Streaming Routing V1 HTTP API #410

merged 2 commits into from Jun 15, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 12, 2023

@hacdias hacdias changed the title wip IPIP-410: Streaming Routing V1 HTTP API May 12, 2023
@hacdias hacdias self-assigned this May 12, 2023
@hacdias hacdias changed the base branch from main to publish-routing May 12, 2023 12:20
@hacdias hacdias force-pushed the publish-routing branch 2 times, most recently from 41cf130 to 9470fd4 Compare May 12, 2023 14:01
Base automatically changed from publish-routing to main May 12, 2023 14:04
@hacdias hacdias force-pushed the issues/344 branch 3 times, most recently from 4661111 to c583e65 Compare May 15, 2023 14:45
@hacdias hacdias marked this pull request as ready for review May 15, 2023 14:45
@hacdias hacdias requested a review from a team as a code owner May 15, 2023 14:45
@hacdias
Copy link
Member Author

hacdias commented May 15, 2023

This is mostly a draft, but I'm opening it for feedback so we can push it as fast as possible. It is finished, please leave me feedback. cc @lidel

@hacdias hacdias force-pushed the issues/344 branch 2 times, most recently from 1b12423 to 1b73368 Compare May 16, 2023 12:06
src/routing/http-routing-v1.md Outdated Show resolved Hide resolved
src/routing/http-routing-v1.md Outdated Show resolved Hide resolved
src/ipips/ipip-0410.md Outdated Show resolved Hide resolved
src/ipips/ipip-0410.md Outdated Show resolved Hide resolved
@hacdias hacdias changed the title IPIP-410: Streaming Routing V1 HTTP API IPIP-0410: Streaming Routing V1 HTTP API May 29, 2023
@hacdias hacdias changed the title IPIP-0410: Streaming Routing V1 HTTP API IPIP-410: Streaming Routing V1 HTTP API May 30, 2023
@hacdias hacdias changed the base branch from main to masih/dlg_routing_ipns May 30, 2023 14:07
@hacdias hacdias force-pushed the masih/dlg_routing_ipns branch 2 times, most recently from 8ff9b91 to 8394e23 Compare May 30, 2023 14:26
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

Moving to "ready for final review" stage.

Added to the agenda of IPFS Implementers WG call on 2023-06-01 but don't expect issues, it is small and everyone agrees we need this for DHT, Helia, Service Workers, etc.

Base automatically changed from masih/dlg_routing_ipns to main June 15, 2023 20:26
@lidel
Copy link
Member

lidel commented Jun 15, 2023

No concerns raised during final ratification during IPFS-Implementers-Sync-2023-06-15, ratified, merging.

@lidel lidel merged commit 383fd01 into main Jun 15, 2023
2 checks passed
@lidel lidel deleted the issues/344 branch June 15, 2023 20:27
@BigLep BigLep mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Ratified
Development

Successfully merging this pull request may close these issues.

IPIP: Streaming Delegated Content Routing
3 participants