Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Links on command list are broken #2

Closed
BrendanBenshoof opened this issue Feb 22, 2015 · 3 comments
Closed

Links on command list are broken #2

BrendanBenshoof opened this issue Feb 22, 2015 · 3 comments
Assignees

Comments

@BrendanBenshoof
Copy link

links for commands on http://ipfs.io/docs/commands/ link back to the wrong page.

links are resolving to : http://ipfs.io/#ipfs-object-links

rather than
http://ipfs.io/docs/commands/#ipfs-object-links

It looks like you are using some javascript to load the page and manipulating the display url. Relative links will not work as intended if you are doing that.

@dylanPowers
Copy link
Contributor

The issue is that <base href="../../"> is set in the html head. We should probably not do that and instead have the navigation links be generated relative to the page they're on.

@jbenet
Copy link
Contributor

jbenet commented Apr 12, 2015

Agreed!


Sent from Mailbox

On Sat, Apr 11, 2015 at 4:17 PM, Dylan Powers notifications@github.com
wrote:

The issue is that is set in the html head. We should probably not do that and instead have the navigation links be generated relative to the page they're on.

Reply to this email directly or view it on GitHub:
#2 (comment)

@RichardLitt
Copy link
Contributor

Should be closed in #62.

@jbenet jbenet removed the codereview label Sep 24, 2015
RichardLitt added a commit to RichardLitt/website that referenced this issue Dec 13, 2016
RichardLitt added a commit to RichardLitt/website that referenced this issue Dec 13, 2016
RichardLitt added a commit to RichardLitt/website that referenced this issue Dec 13, 2016
RichardLitt added a commit to RichardLitt/website that referenced this issue Dec 13, 2016
RichardLitt added a commit to RichardLitt/website that referenced this issue Dec 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants