Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Removed the base html tag #14

Closed
wants to merge 4 commits into from

Conversation

dylanPowers
Copy link
Contributor

Page bases are now set to the actual pages and links in the templates are generated so they are relative to the page they are rendering

Fixes #2

@dylanPowers
Copy link
Contributor Author

@jbenet This has been sitting around for awhile. Look good to you?

@jbenet
Copy link
Contributor

jbenet commented May 31, 2015

@dylanPowers can you rebase? something's off and wont let me merge

Page bases are now set to the actual pages. Links in the templates are
now generated so they are relative to the page they are rendering
@dylanPowers
Copy link
Contributor Author

Rebased. I also noticed a nodejs dependency on nunjucks was missing so I fixed that.

@jbenet
Copy link
Contributor

jbenet commented May 31, 2015

i haven't gone through all links and make sure they work-- how might we do that?

@dylanPowers
Copy link
Contributor Author

I'll look into some broken link checkers. Something like https://www.npmjs.com/package/broken-link-checker will probably do the job All the nodejs implementations don't seem to work as advertised. http://wummel.github.io/linkchecker/ is probably the best option. The downside is that it introduces an additional dependency on Python.
#13 is the relevant issue to this

@dylanPowers
Copy link
Contributor Author

Alright, I ran the "linkchecker" through the website and I can verify that there aren't any broken links. It happily found a few that I missed so good thing I ran it. I'll at the very least add a how-to in the readme on how to run it. I plan on integrating it into the makefile

@jbenet
Copy link
Contributor

jbenet commented Jun 5, 2015

Great! 👍

@jbenet
Copy link
Contributor

jbenet commented Jun 6, 2015

I'll take a look at this later today/tomorrow sorry for delay

@jbenet jbenet self-assigned this Jun 6, 2015
@RichardLitt RichardLitt assigned RichardLitt and unassigned jbenet Sep 12, 2015
@jbenet jbenet closed this Sep 14, 2015
@jbenet jbenet removed the codereview label Sep 14, 2015
@RichardLitt RichardLitt reopened this Sep 14, 2015
@ghost ghost mentioned this pull request Sep 15, 2015
51 tasks
@RichardLitt RichardLitt mentioned this pull request Sep 23, 2015
65 tasks
@RichardLitt
Copy link
Contributor

@jbenet So, I've rebased this on the current, and reverted cf63eb9 (the one where I added docs/commands to all of the commands) --- and it seems to work perfectly. This would've fixed the issue months ago. Pushed fixed branch to https://github.com/ipfs/website/tree/dylanPowers-links-fix.

Can you check it quickly? I think it is ready to go.

@jbenet
Copy link
Contributor

jbenet commented Sep 24, 2015

hmm seems to still say conflicts:

@jbenet
Copy link
Contributor

jbenet commented Sep 24, 2015

@RichardLitt did you push onto this? you must have your own branch-- this is @dylanPowers's. I'll close this.

@jbenet jbenet closed this Sep 24, 2015
@jbenet jbenet mentioned this pull request Sep 24, 2015
@RichardLitt
Copy link
Contributor

@jbenet You found it, pushed to another branch. See #62.

@RichardLitt
Copy link
Contributor

Thanks @dylanPowers !

ghost pushed a commit that referenced this pull request Oct 28, 2017
add a guide on hosting websites in ipfs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links on command list are broken
3 participants