-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jquery #215
Merged
Merged
Remove jquery #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the use of jquery to get the value of the dag path input box. Addresses part of #133
Removes the use of jquery to get the files hash from the elements attrs. Instead we will create a callback for the click that will handle each files unpin. Also cleaned up things a bit, more will be required. Addresses part of #133
Removed editable as it's not used anywhere in the code. Addresses part of #133
Removed the use of jquery to dynamically set the height of the config textarea. Addresses part of #133
Use regular old javascript to retrieve the value from the event and trim off the extra. Addresses part of #133
Removed the hover class addition/removal as it appeared not to be doing anything, also used good-ol JavaScript to perform click operation. Addresses part of #133
Moved the FileItem to a seperate file. Switched to using Glyphicon instead of a div for block element.
Changes location of key to remove error.
Woo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.