Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jquery #133

Closed
6 tasks done
dignifiedquire opened this issue Dec 21, 2015 · 5 comments
Closed
6 tasks done

Remove jquery #133

dignifiedquire opened this issue Dec 21, 2015 · 5 comments
Labels
exp/intermediate Prior experience is likely helpful

Comments

@dignifiedquire
Copy link
Member

We should drop jquery as a dependency and replace all instances with alternatives. For all things bootstrap we should use react-bootstrap and drop bootstrap with jquery

  • scripts/pages/files.js:5:16
  • scripts/pages/objects.js:3:16
  • scripts/views/config.js:3:16
  • scripts/views/editable.js:2:16
  • scripts/views/filelist.js:2:16
  • scripts/views/page.js:5:16
@dignifiedquire dignifiedquire added help wanted Seeking public contribution on this issue exp/intermediate Prior experience is likely helpful labels Dec 21, 2015
@RichardLitt RichardLitt mentioned this issue Dec 31, 2015
Closed
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from views/page.js
f470dfe 
Removes the use of jquery to get the value of the dag path input box.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from views/filelist.js
c04eb4e 
Removes the use of jquery to get the files hash from the elements
attrs. Instead we will create a callback for the click that will handle
each files unpin.

Also cleaned up things a bit, more will be required.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Editable is no longer used
7099166 
Removed editable as it's not used anywhere in the code.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from views/config.js
6edaa90 
Removed the use of jquery to dynamically set the height of the config
textarea.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from pages/object.js
56c99c8 
Use regular old javascript to retrieve the value from the event and
trim off the extra.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from pages/files.js
8fc543f 
Removed the hover class addition/removal as it appeared not to be doing
anything, also used good-ol JavaScript to perform click operation.

Addresses part of #133
@travisperson travisperson mentioned this issue Jan 3, 2016
Merged
@jbenet jbenet added the status/in-progress In progress label Jan 3, 2016
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from views/page.js
e206854 
Removes the use of jquery to get the value of the dag path input box.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from views/filelist.js
1365236 
Removes the use of jquery to get the files hash from the elements
attrs. Instead we will create a callback for the click that will handle
each files unpin.

Also cleaned up things a bit, more will be required.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Editable is no longer used
c7d517e 
Removed editable as it's not used anywhere in the code.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from views/config.js
c55d960 
Removed the use of jquery to dynamically set the height of the config
textarea.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from pages/object.js
8e60957 
Use regular old javascript to retrieve the value from the event and
trim off the extra.

Addresses part of #133
travisperson pushed a commit that referenced this issue Jan 3, 2016
Remove jquery from pages/files.js
6f6a631 
Removed the hover class addition/removal as it appeared not to be doing
anything, also used good-ol JavaScript to perform click operation.

Addresses part of #133
@daviddias
Copy link
Member

@travisperson made this on #159 🎉

@jbenet jbenet removed the status/in-progress In progress label Jan 5, 2016
@dignifiedquire dignifiedquire reopened this Jan 5, 2016
@dignifiedquire
Copy link
Member Author

Please do not close until it's merged :)

@dignifiedquire dignifiedquire added status/in-progress In progress and removed help wanted Seeking public contribution on this issue labels Jan 5, 2016
@luigiplr
Copy link
Contributor

Doing in: #195

@dignifiedquire
Copy link
Member Author

Fixed in #159

@jbenet jbenet removed the status/in-progress In progress label Jan 20, 2016
@RichardLitt
Copy link
Member

Thanks!

@snyk-bot snyk-bot mentioned this issue Dec 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jbenet @travisperson @dignifiedquire @RichardLitt @daviddias @luigiplr