Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for async #25

Closed
andrew-ld opened this issue May 4, 2020 · 3 comments · Fixed by #32
Closed

support for async #25

andrew-ld opened this issue May 4, 2020 · 3 comments · Fixed by #32

Comments

@andrew-ld
Copy link

we are in 2020, the network is used asynchronously now
@UmanShahzad
Copy link
Contributor

UmanShahzad commented Oct 23, 2020 •
edited
Loading

Hey @andrew-ld , that's right, though the network has been used asynchronously for as long as it's been around! The Python ecosystem is catching up.

I'll look into adding an async version of the handler soon, while keeping the synchronous versions around for users without coroutines support in their version of Python, and for backwards compatibility. This might require a separate package to do right, though, or simply drop support in newer package versions for the synchronous stuff.

@andrew-ld
Copy link
Author

good!

This was referenced Oct 27, 2020
Closed
Merged
@UmanShahzad
Copy link
Contributor

@andrew-ld check out v4.0.0 - it has async support. Let me know if there are any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Async handler ipinfo/python
2 participants
@UmanShahzad @andrew-ld