Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rethink static name checking #78

Closed
jGaboardi opened this issue Aug 6, 2020 · 0 comments
Closed

rethink static name checking #78

jGaboardi opened this issue Aug 6, 2020 · 0 comments
Assignees
Milestone

Comments

@jGaboardi
Copy link
Member

From Jonathan:

b8a2860 still hard-codes the expected length for geo codes (now either 2 or 3 characters instead of exactly 3). I’m not sure it’s worth fixing now, but to handle potentially longer codes in the future, I’d suggest instead grabbing a set of characters from “c” that is equal in length to “geo” and comparing those strings.

try comparing to self.source_geo/self.target_geo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant