Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: Bootstrap local node to DHT #492

Closed
bgins opened this issue Jan 8, 2024 · 0 comments · Fixed by #547
Closed

Network: Bootstrap local node to DHT #492

bgins opened this issue Jan 8, 2024 · 0 comments · Fixed by #547
Assignees
@zeeshanlakhani
Labels
networking Features, functionality involving networking

Comments

@bgins
Copy link
Contributor

bgins commented Jan 8, 2024

Summary

Problem

We don't bootstrap a local node into the DHT.

Impact

Without bootstrapping, DHT lookups may not be optimal because adding the local node makes for a robust routing table with better closest neighbor information.

Solution

Add a bootstrap call. Note that this must be called with at least one node already in the DHT.

Receipt and workflow info quorum counts may effected by this change and should be updated as needed.
@bgins bgins added the networking Features, functionality involving networking label Jan 8, 2024
zeeshanlakhani added a commit that referenced this issue Feb 3, 2024
@zeeshanlakhani
refactor: transport handling for ws & quic as fallback
f0199e4 
Includes:

- dns fallback update
- CLI removal of -w for running workflows; it's not a positional argument (the first one on run)
  * related to #489
- Closes #492 with local node bootstrapping
zeeshanlakhani added a commit that referenced this issue Feb 5, 2024
@zeeshanlakhani
fix: add handling of dns multiaddrs
cfe94d2 
refactor: transport handling for ws & quic as fallback

Includes:

- dns fallback update
- CLI: removal of -w for running workflows; it's now a positional argument (the first one on run)
  * related to #489
- CLI: whoami command which showcases nodeinfo, e.g. peer_id and listener addrs/connections
  * related to #489
- Closes #492 with local node bootstrapping
zeeshanlakhani added a commit that referenced this issue Feb 5, 2024
@zeeshanlakhani
fix: add handling of dns multiaddrs
c87404e 
refactor: transport handling for ws & quic as fallback

Includes:

- dns fallback update
- CLI: removal of -w for running workflows; it's now a positional argument (the first one on run)
  * related to #489
- CLI: node command which showcases nodeinfo, e.g. peer_id and listener addrs/connections
  * related to #489
- Closes #492 with local node bootstrapping
- Closes #297
- Closes #497
@zeeshanlakhani zeeshanlakhani mentioned this issue Feb 5, 2024
Merged
@zeeshanlakhani zeeshanlakhani self-assigned this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeeshanlakhani zeeshanlakhani

Labels
networking Features, functionality involving networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add handling of dns multiaddrs + bootstrapping + CLI / Conn changes ipvm-wg/homestar
2 participants
@zeeshanlakhani @bgins