fix: add handling of dns multiaddrs + bootstrapping + CLI / Conn changes #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/dns+star
branch
2 times, most recently
from
04962ea
to
02f07f4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
==========================================
+ Coverage 74.91% 77.07% +2.15%
==========================================
Files 83 83
Lines 9537 9778 +241
==========================================
+ Hits 7145 7536 +391
+ Misses 2392 2242 -150
|
zeeshanlakhani
force-pushed
the
zl/dns+star
branch
from
94c0e72
to
f0199e4
Compare
12 tasks
zeeshanlakhani
force-pushed
the
zl/dns+star
branch
from
ff76aed
to
cfe94d2
Compare
zeeshanlakhani
changed the title
zeeshanlakhani
force-pushed
the
zl/dns+star
branch
from
191f0ac
to
c191d39
Compare
refactor: transport handling for ws & quic as fallback Includes: - dns fallback update - CLI: removal of -w for running workflows; it's now a positional argument (the first one on run) * related to #489 - CLI: node command which showcases nodeinfo, e.g. peer_id and listener addrs/connections * related to #489 - Closes #492 with local node bootstrapping - Closes #297 - Closes #497
zeeshanlakhani
force-pushed
the
zl/dns+star
branch
from
c191d39
to
c87404e
Compare
Merged
bgins
reviewed
Feb 5, 2024
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com> Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
bgins
reviewed
Feb 5, 2024
bgins
reviewed
Feb 5, 2024
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com> Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
bgins
reviewed
Feb 5, 2024
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com> Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com> Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
zeeshanlakhani
changed the title
bgins
reviewed
Feb 5, 2024
bgins
reviewed
Feb 5, 2024
bgins
reviewed
Feb 5, 2024
bgins
approved these changes
Feb 5, 2024
zeeshanlakhani
pushed a commit
that referenced
this pull request
Feb 21, 2024
## 🤖 New release * `homestar-runtime`: 0.1.1 -> 0.2.0 (⚠️ API breaking changes) * `homestar-invocation`: 0.1.1 -> 0.2.0 (✓ API compatible changes) * `homestar-wasm`: 0.1.1 -> 0.2.0 (✓ API compatible changes) * `homestar-workflow`: 0.1.1 -> 0.2.0 (✓ API compatible changes) ###⚠️ `homestar-runtime` breaking changes ``` --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/enum_variant_added.ron Failed in: variant Command:Node in /tmp/.tmp7PLiiL/homestar/homestar-runtime/src/cli.rs:149 variant Command:Info in /tmp/.tmp7PLiiL/homestar/homestar-runtime/src/cli.rs:155 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `homestar-runtime` <blockquote> ## [0.2.0](homestar-runtime-v0.1.1...homestar-runtime-v0.2.0) - 2024-02-20 ### Added - Add OpenRPC API docs and associated JSON Schemas ([#534](#534)) - redial `node_addresses` at an interval on connection close ([#529](#529)) ### Fixed - add handling of dns multiaddrs + bootstrapping + CLI / Conn changes ([#547](#547)) ### Other - deps + flake cleanup ([#581](#581)) - Allow dead code default timeout ([#577](#577)) - Update homestar-functions to use cargo component ([#576](#576)) - fix transport order for wss possibility ([#563](#563)) - small comment, sorry ([#561](#561)) - move away from deadlines dealing w/ the runner and wasi-preview 2 wasmtime ([#560](#560)) - docker updates with info command and rpc host update ([#558](#558)) - just test conn ([#544](#544)) - handle this evil workflow_info test ([#543](#543)) - remove unnecessary deps and add tooling for those checks ([#541](#541)) - [chore(cargo)](deps): bump puffin from 0.18.1 to 0.19.0 ([#537](#537)) - updates/flaky kills on ci ([#540](#540)) - release docs and cp readmes ([#530](#530)) - port selection and test config generation macro ([#528](#528)) - [chore(cargo)](deps): bump serde_with from 3.4.0 to 3.5.0 ([#524](#524)) - [chore(cargo)](deps): bump moka from 0.12.3 to 0.12.4 ([#525](#525)) </blockquote> ## `homestar-invocation` <blockquote> ## [0.2.0](homestar-invocation-v0.1.1...homestar-invocation-v0.2.0) - 2024-02-20 ### Added - Add OpenRPC API docs and associated JSON Schemas ([#534](#534)) ### Other - deps + flake cleanup ([#581](#581)) - Update homestar-functions to use cargo component ([#576](#576)) - move away from deadlines dealing w/ the runner and wasi-preview 2 wasmtime ([#560](#560)) - remove unnecessary deps and add tooling for those checks ([#541](#541)) - release docs and cp readmes ([#530](#530)) </blockquote> ## `homestar-wasm` <blockquote> ## [0.2.0](homestar-wasm-v0.1.1...homestar-wasm-v0.2.0) - 2024-02-20 ### Other - deps + flake cleanup ([#581](#581)) - Update homestar-functions to use cargo component ([#576](#576)) - move away from deadlines dealing w/ the runner and wasi-preview 2 wasmtime ([#560](#560)) - remove unnecessary deps and add tooling for those checks ([#541](#541)) - release docs and cp readmes ([#530](#530)) </blockquote> ## `homestar-workflow` <blockquote> ## [0.2.0](homestar-workflow-v0.1.1...homestar-workflow-v0.2.0) - 2024-02-20 ### Added - Add OpenRPC API docs and associated JSON Schemas ([#534](#534)) ### Other - deps + flake cleanup ([#581](#581)) - remove unnecessary deps and add tooling for those checks ([#541](#541)) - release docs and cp readmes ([#530](#530)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: release-plz-ipvm-wg[bot] <144082651+release-plz-ipvm-wg[bot]@users.noreply.github.com> Co-authored-by: release-plz-ipvm-wg[bot] <144082651+release-plz-ipvm-wg[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add handling of dns multiaddrs and added kad bootstrapping
Closes #545.
Closes #492.
refactor: transport handling for ws & quic as fallback
Includes:
nodecommand which showcases nodeinfo, e.g. peer_id and listener addrs/connectionsinfocommand showcasing version, build-git-sha, and features built with. We can extend this later with more build information.