Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Run examples as part of CI #497

Closed
zeeshanlakhani opened this issue Jan 10, 2024 · 0 comments · Fixed by #547
Closed

Testing: Run examples as part of CI #497

zeeshanlakhani opened this issue Jan 10, 2024 · 0 comments · Fixed by #547
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zeeshanlakhani
Copy link
Contributor

Summary

As we make changes, it'd be great to make sure all examples can continue to run, so we should integrate running them as part of CI.
@zeeshanlakhani zeeshanlakhani added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 10, 2024
@zeeshanlakhani zeeshanlakhani mentioned this issue Feb 5, 2024
Merged
zeeshanlakhani added a commit that referenced this issue Feb 5, 2024
@zeeshanlakhani
fix: add handling of dns multiaddrs
c87404e 
refactor: transport handling for ws & quic as fallback

Includes:

- dns fallback update
- CLI: removal of -w for running workflows; it's now a positional argument (the first one on run)
  * related to #489
- CLI: node command which showcases nodeinfo, e.g. peer_id and listener addrs/connections
  * related to #489
- Closes #492 with local node bootstrapping
- Closes #297
- Closes #497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add handling of dns multiaddrs + bootstrapping + CLI / Conn changes ipvm-wg/homestar
1 participant
@zeeshanlakhani