Merge pull request #730 from ellert/warn-test-fix

Fix warning test
ipython · Jun 30, 2022 · 6bc6d94 · 6bc6d94
2 parents 367cd36 + ee49406
commit 6bc6d94
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/ipyparallel/tests/test_client.py b/ipyparallel/tests/test_client.py
@@ -626,23 +626,25 @@ def test_warning_on_hostname_match(self):
                     c = self.connect_client()
                 c.close()
             with mock.patch('socket.gethostname', lambda: location):
+                c = None
                 try:
-                    c = self.connect_client()
+                    with warnings.catch_warnings():
+                        warnings.simplefilter("error", category=RuntimeWarning)
+                        c = self.connect_client()
                 finally:
                     if c:
-                        warnings.simplefilter("ignore", category=RuntimeWarning)
                         c.close()
 
     def test_local_ip_true_doesnt_trigger_warning(self):
         with mock.patch('ipyparallel.client.client.is_local_ip', lambda x: True):
             c = None
-            with warnings.catch_warnings():
-                warnings.simplefilter("error")
-                try:
+            try:
+                with warnings.catch_warnings():
+                    warnings.simplefilter("error", category=RuntimeWarning)
                     c = self.connect_client()
-                finally:
-                    if c:
-                        c.close()
+            finally:
+                if c:
+                    c.close()
 
     def test_wait_for_engines(self):
         n = len(self.client)