Skip to content

Commit

Permalink
Merge pull request #1815 from ellisonbg/nbsavebug
Browse files Browse the repository at this point in the history
Make : invalid in filenames in the Notebook JS code.

This only prevents : in the filenames on the JavaScript side of things. Handling this on the server side will be a separate issue that is related to other open issue. I will update those to reflect this. 

closes #1781
  • Loading branch information
minrk committed Jun 6, 2012
2 parents 9f36bf5 + e264b9b commit 66a567b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion IPython/frontend/html/notebook/static/js/notebook.js
Expand Up @@ -28,7 +28,7 @@ var IPython = (function (IPython) {
this.control_key_active = false;
this.notebook_id = null;
this.notebook_name = null;
this.notebook_name_blacklist_re = /[\/\\]/;
this.notebook_name_blacklist_re = /[\/\\:]/;
this.nbformat = 3 // Increment this when changing the nbformat
this.style();
this.create_elements();
Expand Down
2 changes: 1 addition & 1 deletion IPython/frontend/html/notebook/static/js/savewidget.js
Expand Up @@ -83,7 +83,7 @@ var IPython = (function (IPython) {
$(this).find('h3').html(
"Invalid notebook name. Notebook names must "+
"have 1 or more characters and can contain any characters " +
"except / and \\. Please enter a new notebook name:"
"except :/\\. Please enter a new notebook name:"
);
} else {
IPython.notebook.set_notebook_name(new_name);
Expand Down

0 comments on commit 66a567b

Please sign in to comment.