You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you change the name of a notebook by clicking on the notebook title in the browser, and the new name includes a colon, the notebook is "saved" without objection, while in the background the ipynb file is wiped -- the filename is truncated at the colon and the file is empty. This is not apparent in the browser until you close the notebook. This is on Windows.
I discovered this by successively changing the names of a set of 5 notebooks to include colons, and continued to make changes to the notebooks, saving, etc. Then I closed them and later went to re-open them to discover everything was gone. There was never any warning at all while in the browser. Given that there is no warning that the notebook title == filename and colons are a fairly common character, this strikes me as a pretty serious issue!
The text was updated successfully, but these errors were encountered:
Make : invalid in filenames in the Notebook JS code.
This only prevents : in the filenames on the JavaScript side of things. Handling this on the server side will be a separate issue that is related to other open issue. I will update those to reflect this.
closesipython#1781
If you change the name of a notebook by clicking on the notebook title in the browser, and the new name includes a colon, the notebook is "saved" without objection, while in the background the ipynb file is wiped -- the filename is truncated at the colon and the file is empty. This is not apparent in the browser until you close the notebook. This is on Windows.
I discovered this by successively changing the names of a set of 5 notebooks to include colons, and continued to make changes to the notebooks, saving, etc. Then I closed them and later went to re-open them to discover everything was gone. There was never any warning at all while in the browser. Given that there is no warning that the notebook title == filename and colons are a fairly common character, this strikes me as a pretty serious issue!
The text was updated successfully, but these errors were encountered: