WIP: Transform linenumber #2402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 11, 2012 16:31
…ed by extensions.
For backwards compatibility, we could also inspect the function to see if it takes 2 arguments, and if not, just pass in the line string.
|
Thanks - I'm not sure line number is quite the right way to do this, but I do have some kind of stateful transformers in mind. And I agree that we need to move the list of transformations out where it can be accessed. (This falls under the heading of #2293, aka IPEP 2) |
|
@jasongrout I'm going to close this one in favour of #2447 - I'm trying to bring our PR count down a bit. Do keep an eye on that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it possible to modify the transforms applied and also modifies the transformation code to pass the line numbers.
This isn't ready to be merged (I'm sure there are other places in the code that would need to be changed), but it does illustrate the sorts of changes that would be great for the Sage customizations.
See also http://mail.scipy.org/pipermail/ipython-dev/2012-September/010239.html
(WIP stands for Work in Progress...)