add QtConsoleApp using newapplication #492
Conversation
* app_name -> name. * config_file_paths is properly typed.
also include choices in help output for Enums
initialize loads config, and ensures command-line opts override those specified in config files.
Old files are left in place, until applications make the transition to newapp.
ProfileDir is adapted from old ClusterDir
previously failing test included
doing ipython foo="" would fail as invalid.
|
This is awesome!!!! I have only given this a quick look through, but I am very excited to look at this more! |
|
One thing that's missing is the KernelApp has configurables, etc. for exec_lines, exec_files, etc., but the code to actually run them isn't there. This code will be exactly identical to that in the terminal IPythonApp, so I'm wondering if there should be a subclass somewhere, perhaps a core.shellapp.InteractiveShellApp. |
|
This branch is now based on the terminal IPython code in #485, due to a common subclass between TerminalIPythonApp and IPKernelApp. Until that's merged into newapp, the more accurate diff for this PR is here This means that loading extensions, initial startup scripts, etc. are now supported by the qtconsole. |
useful for delegating subapps, which would previously conflict if both apps were launched with instance()
This way later calls to App.instance() will return the running application, whereas calling App() would create an isolated Application object.
…lapp Now there's a class for IPKernel to inherit from in the qt code
This way later calls to App.instance() will return the running application, whereas calling App() would create an isolated Application object.
The inline backend now has preliminary config support for rc and figure format.
Also set the default editor to notepad on Windows.
This way later calls to App.instance() will return the running application, whereas calling App() would create an isolated Application object.
Now 'ipython qtconsole' will behave the same as 'ipython-qtconsole'
|
merged into newapp as f6b7029 |
ipython-qtconsole now uses the newapplication and config system, and the inline svg/png switch is configurable, as well as QtConsole font family/size.