Execution count & SyntaxError #633

Closed
takluyver opened this Issue Jul 29, 2011 · 3 comments

Comments

Projects
None yet
2 participants
@takluyver
Member

takluyver commented Jul 29, 2011

If run_cell is called with store_history=False, we don't increment the execution count. Except that, reading the code, we do if the code we're trying to run has a syntax error. We should be consistent.

This is low priority, because end user code is always run with store_history=True.

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Nov 28, 2011

Member

@takluyver, is this still an issue? I was wondering if all the recent work might have fixed it...

Member

fperez commented Nov 28, 2011

@takluyver, is this still an issue? I was wondering if all the recent work might have fixed it...

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Nov 28, 2011

Member

I checked a few days ago, and it's still the case. It's a simple fix, I'll try to tidy it up later.

Member

takluyver commented Nov 28, 2011

I checked a few days ago, and it's still the case. It's a simple fix, I'll try to tidy it up later.

@ghost ghost assigned takluyver Nov 28, 2011

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Nov 29, 2011

Member

Great, thanks!

Member

fperez commented Nov 29, 2011

Great, thanks!

takluyver added a commit to takluyver/ipython that referenced this issue Nov 30, 2011

@takluyver takluyver closed this in 762b0ea Dec 5, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment