Skip to content

Execution count & SyntaxError #633

Closed
takluyver opened this Issue Jul 29, 2011 · 3 comments

2 participants

@takluyver
IPython member

If run_cell is called with store_history=False, we don't increment the execution count. Except that, reading the code, we do if the code we're trying to run has a syntax error. We should be consistent.

This is low priority, because end user code is always run with store_history=True.

@fperez
IPython member
fperez commented Nov 28, 2011

@takluyver, is this still an issue? I was wondering if all the recent work might have fixed it...

@takluyver
IPython member

I checked a few days ago, and it's still the case. It's a simple fix, I'll try to tidy it up later.

@takluyver takluyver was assigned Nov 28, 2011
@fperez
IPython member
fperez commented Nov 29, 2011

Great, thanks!

@takluyver takluyver added a commit to takluyver/ipython that referenced this issue Nov 30, 2011
@takluyver takluyver After a SyntaxError in code run by run_cell, only increment execution…
… count where we would normally.

Closes gh-633
a9d69f2
@takluyver takluyver added a commit that closed this issue Dec 5, 2011
@takluyver takluyver After a SyntaxError in code run by run_cell, only increment execution…
… count where we would normally.

Closes gh-633
closes gh-1070
762b0ea
@takluyver takluyver closed this in 762b0ea Dec 5, 2011
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@takluyver takluyver After a SyntaxError in code run by run_cell, only increment execution…
… count where we would normally.

Closes gh-633
closes gh-1070
26c83b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.