Skip to content
This repository

Execution count & SyntaxError #633

Closed
takluyver opened this Issue July 29, 2011 · 3 comments

2 participants

Thomas Kluyver Fernando Perez
Thomas Kluyver
Collaborator

If run_cell is called with store_history=False, we don't increment the execution count. Except that, reading the code, we do if the code we're trying to run has a syntax error. We should be consistent.

This is low priority, because end user code is always run with store_history=True.

Fernando Perez
Owner

@takluyver, is this still an issue? I was wondering if all the recent work might have fixed it...

Thomas Kluyver
Collaborator

I checked a few days ago, and it's still the case. It's a simple fix, I'll try to tidy it up later.

Fernando Perez
Owner

Great, thanks!

Thomas Kluyver takluyver referenced this issue from a commit in takluyver/ipython November 30, 2011
Thomas Kluyver After a SyntaxError in code run by run_cell, only increment execution…
… count where we would normally.

Closes gh-633
a9d69f2
Thomas Kluyver takluyver closed this issue from a commit November 30, 2011
Thomas Kluyver After a SyntaxError in code run by run_cell, only increment execution…
… count where we would normally.

Closes gh-633
closes gh-1070
762b0ea
Thomas Kluyver takluyver closed this in 762b0ea December 05, 2011
Brian E. Granger ellisonbg referenced this issue from a commit January 10, 2012
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.