Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution count & SyntaxError #633

Closed
takluyver opened this issue Jul 29, 2011 · 3 comments
Closed

Execution count & SyntaxError #633

takluyver opened this issue Jul 29, 2011 · 3 comments
Assignees
Labels
Milestone

Comments

@takluyver
Copy link
Member

If run_cell is called with store_history=False, we don't increment the execution count. Except that, reading the code, we do if the code we're trying to run has a syntax error. We should be consistent.

This is low priority, because end user code is always run with store_history=True.

@fperez
Copy link
Member

fperez commented Nov 28, 2011

@takluyver, is this still an issue? I was wondering if all the recent work might have fixed it...

@takluyver
Copy link
Member Author

I checked a few days ago, and it's still the case. It's a simple fix, I'll try to tidy it up later.

@ghost ghost assigned takluyver Nov 28, 2011
@fperez
Copy link
Member

fperez commented Nov 29, 2011

Great, thanks!

takluyver added a commit to takluyver/ipython that referenced this issue Nov 30, 2011
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants