Generate package list automatically in find_packages #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fperez is there any reason that we should not do it this way? The only one I see is that you can change what's installed by creating new files inside the IPython dir, but this doesn't strike me as anything but an improvement. |
|
Nope, that's certainly the right way to do it. Merge away! |
Previously, the package list was manually specified, which meant that it became out of date any time a package was added, and IPython would become uninstallable. This would not be noticed for some time by developers, who always use `setupegg.py --develop` or symlinks. This update immediately revealed that IPython.zmq.tests and IPython.extensions.tests were never included in 0.11. Other than that, there is no difference in the package list.
jasongrout
added a commit
to jasongrout/ipython
that referenced
this pull request
Feb 16, 2015
A bug in pyzmq forces us to have a workaround, which can be deleted when the pyzmq dependency is upgraded to fix pyzmq issue ipython#646. Thanks to @minrk for helping work on the code and also for the bugfix in pyzmq.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the package list was manually specified, which meant that it became out of date any time a package was added, and IPython would become uninstallable. This would not be noticed for some time by developers, who always use
setupegg.py --developor symlinks.This update immediately revealed that IPython.zmq.tests and IPython.extensions.tests were never included in 0.11. Other than that, there is no difference in the package list.
Wait for after 0.11, in case of unforeseen side effects.