Two-process terminal frontend #708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this does a lot of the boiler plate for us, so Omar's communication code is used in place of run_cell / complete. Now colors, prompts, indentation, cl-args, etc. are all inherited from regular existing code. keyboard interrupts don't work yet, the kernel just dies...
|
this would be really nice to get back plain terminal ipython with the two-process connection capability. For one, it would enable Django-shell embedding to work with vim-ipython in a simlpe and straightfoward manner - which was recently requested in ivanov/vim-ipython#11 and I pointed them to this PR. |
|
closing this one, since #864 will supersede it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #433 to use TerminalInteractiveShell/TerminalIPythonApp subclasses, so all our configuration, etc. is inherited as you would expect.
Not ready for merge because, among other things, ctrl-C crashes the kernel. Mostly posted as a starting point for someone else to take over finishing this client.
As far as I can tell, it's already quite functional as long as you never hit ctrl-C :).