Skip to content
This repository

Put qtconsole forground when launching #1147

Merged
merged 1 commit into from over 2 years ago

3 participants

Matthias Bussonnier Fernando Perez Min RK
Matthias Bussonnier
Collaborator

That's a one line change, but it is nice to have the qtconsole on top and in focus when you invoke it.

Fernando Perez
Owner

The window is already always raised for me on ubuntu. On what platforms is this actually necessary?

We're reaching RC freeze pretty quickly, so at this point even small changes should be considered very carefully and unless truly necessary and safe, they should wait for 0.13.

Matthias Bussonnier
Collaborator

For me, on mac (work and home), it is always the lower window when launching, and last in the alt+tab switcher.
I'm ok with waiting for 0.13, and it's all but necessary it just an UI detail.

Fernando Perez
Owner

@minrk, you're on OSX too, can you confirm that you have this problem as well? The change is small so I'm OK putting it in before 0.12RC, but only if we confirm it affects all OSX users and that the fix indeed does the job.

Min RK
Owner

Indeed, the Terminal does maintain focus when launching a qtconsole, and this commit changes that. The change seems sensible to me.

Fernando Perez
Owner

Fair enough, let's put it in then. I'll rebase now to avoid the merge handle and will push.

Fernando Perez fperez merged commit 8f8e165 into from December 13, 2011
Fernando Perez fperez closed this December 13, 2011
Fernando Perez
Owner

Never mind, it was already a ff merge so no rebase needed. Pushed. Thanks to both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Dec 13, 2011
Matthias Bussonnier put qtconsole forground when launching 8f8e165
This page is out of date. Refresh to see the latest.
1  IPython/frontend/qt/console/qtconsoleapp.py
@@ -334,6 +334,7 @@ def start(self):
334 334
 
335 335
         # draw the window
336 336
         self.window.show()
  337
+        self.window.raise_()
337 338
 
338 339
         # Start the application main loop.
339 340
         self.app.exec_()
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.