Put qtconsole forground when launching #1147

Merged
merged 1 commit into from Dec 13, 2011

Projects

None yet

3 participants

@Carreau
Member
Carreau commented Dec 13, 2011

That's a one line change, but it is nice to have the qtconsole on top and in focus when you invoke it.

@fperez
Member
fperez commented Dec 13, 2011

The window is already always raised for me on ubuntu. On what platforms is this actually necessary?

We're reaching RC freeze pretty quickly, so at this point even small changes should be considered very carefully and unless truly necessary and safe, they should wait for 0.13.

@Carreau
Member
Carreau commented Dec 13, 2011

For me, on mac (work and home), it is always the lower window when launching, and last in the alt+tab switcher.
I'm ok with waiting for 0.13, and it's all but necessary it just an UI detail.

@fperez
Member
fperez commented Dec 13, 2011

@minrk, you're on OSX too, can you confirm that you have this problem as well? The change is small so I'm OK putting it in before 0.12RC, but only if we confirm it affects all OSX users and that the fix indeed does the job.

@minrk
Member
minrk commented Dec 13, 2011

Indeed, the Terminal does maintain focus when launching a qtconsole, and this commit changes that. The change seems sensible to me.

@fperez
Member
fperez commented Dec 13, 2011

Fair enough, let's put it in then. I'll rebase now to avoid the merge handle and will push.

@fperez fperez merged commit 8f8e165 into ipython:master Dec 13, 2011
@fperez
Member
fperez commented Dec 13, 2011

Never mind, it was already a ff merge so no rebase needed. Pushed. Thanks to both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment