Updated autogen_magics.py to Pathlib Path #12604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalvirtuoso
changed the title
|
Can a reviewer kindly review this for Hacktoberfest? I'd love feedback and am happy to help! :) |
|
Apologies, we've been quite busy, i've marked as "hacktoberfest-accepted" so it should count toward your total even if not merged. Let me know if it's not the case. There are conflicts as other pull-request were merged; if you want to try to fix the conflict let me know otherwise I can do that myself – up to you and if you want to learn ! Looking forward to your next contribution. |
|
No worries! Thank you for the reply! I'd be glad to work on resolving the conflicts. |
|
@Carreau Everything should be good to go. Please advise with anything else recommended, thanks! |
|
THanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a file (autogen_magics.py) where Pathlib Path could replace os entirely. Made the changes!
#12515