use pathlib in tools/gh_api.py #12806
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kindly ask if anyone know what's wrong here? Seems like it fails the test with Python 3.8. Any advice on improvement will be appreciated. Thanks! |
|
The CI failure looks unrelated. The failure is here: https://travis-ci.com/github/ipython/ipython/jobs/479778266#L773 |
MrMino
requested changes
Apr 3, 2021
| @@ -276,8 +276,7 @@ def post_download(project, filename, name=None, description=""): | |||
| """Upload a file to the GitHub downloads area""" | |||
| if name is None: | |||
| name = Path(filename).name | |||
| with open(filename, 'rb') as f: | |||
| filedata = f.read() | |||
| filedata = Path(filename).read_bytes() | |||
There was a problem hiding this comment.
You could improve this method further by making sure it creates Path only once - currently it does twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #12515
This is my first contribution here so please guide me if I'm doing anything wrong.
@Carreau, please review this PR.
Thank you.