HeartMonitor.period should be an Integer #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millisecond times should generally be integers, because any time they are specified with fractional precision it is probable that the user believes the units are seconds, and an error should be raised.
|
This looks ready to merge. |
minrk
added a commit
that referenced
this pull request
Jan 18, 2012
HeartMonitor.period is now an Integer millisecond times should generally be integers, because any time they are specified with fractional precision it is probable that the user believes the units are seconds, and an error should be raised. closes #1281
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
HeartMonitor.period is now an Integer millisecond times should generally be integers, because any time they are specified with fractional precision it is probable that the user believes the units are seconds, and an error should be raised. closes ipython#1281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
millisecond times should generally be integers, because any time they are specified with fractional precision it is probable that the user believes the units are seconds, and an error should be raised.
closes #1281