Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior of ipython notebook --port=... #1817

Closed
wants to merge 1 commit into from

Conversation

bfroehle
Copy link
Contributor

Previously ipython notebook took the port parameter as a suggested place to
start looking for open ports. With this commit:

  • ipython notebook : start at port 8888 and try random ports until success
  • ipython notebook --port=1234 : use port 1234, failing if it is not available

Closes gh-1750.

Previously ipython notebook took the port parameter as a suggested place to
start looking for open ports.  With this commit:
* `ipython notebook` : start at port 8888 and try random ports until success
* `ipython notebook --port=1234` : use port 1234, failing if it is not available

Closes ipythongh-1750
@bfroehle
Copy link
Contributor Author

I first considered implementing this using another Trait:

try_other_ports = Bool(True)
def _port_changed(self, name, old, new):
    self.try_other_ports = False

But this lead to inconsistent behavior as ipython noteboook --port=8888 doesn't trigger the _port_changed function.

@ellisonbg
Copy link
Member

Please see my recent comment on #1750. I want to maintain the ability to set the starting point of random port ranges, which my proposal would do.

@bfroehle
Copy link
Contributor Author

I'll close this for now, to keep the discussion in #1750.

@bfroehle bfroehle closed this May 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let the user disable random port selection
2 participants