Hook to add alternative notebook managers #2155
Conversation
| @@ -274,6 +275,9 @@ class NotebookApp(BaseIPythonApplication): | |||
| # file to be opened in the notebook server | |||
| file_to_run = Unicode('') | |||
|
|
|||
| # Which alternative NotebookManager to use | |||
| nbmgr = Unicode(u'', config=True, help="""Alternative notebook manager module""") | |||
There was a problem hiding this comment.
let's follow conventions and call this notebook_manager_class
There was a problem hiding this comment.
Note there's also a more specific trait for this sort of thing - DottedObjectName.
|
This PR: Has a significant refactor of the notebook manager logic to make On Tue, Jul 17, 2012 at 8:49 AM, Benjie Chen
Brian E. Granger |
With certain sets of arguments `compile_flags` might be left as `None`. This caused IPython to internally raise a TypeError when it tried to do a bitwise or between `shell.compile.flags` and `PyCF_ONLY_AST` in `CachingCompiler.ast_parse`. The regression was introduced in: b70ac12 embed(): Default to the future compile flags of the calling frame.
track sha of master in test_pr messages
Fix regression in embed() from pull-request #2096.
Fix missing HTML iframe end tags in notebook example.
|
I see that those commits have changed... |
|
Yes you are right. It was a "mistake" on my part. I am investigating if I can just "cancel" the pull request and entirely use On Wed, Aug 8, 2012 at 11:21 AM, Bussonnier Matthias <
|
|
Don't worry, you can force-push later or close/reopen with a new branch as target if you wish to. |
|
I am closing this pull request. Instead pull 2045 works fine with |
I added a hook to add alternative notebook managers. See https://github.com/benjiec/django-ipy-nbmgr for an example of a notebook manager that stores notebooks in database, and versions them.