DOC: fix links to matplotlib, notebook docs #4022
Conversation
I've added a link to pandas, made all matplotlib links point to matplotlib.org, and fixed a link in the notebook help menu to point to our new notebook.html, now that htmlnotebook.html is a redirect. Whoever ends up merging this PR should backport it to 1.x.
| <li><a href="http://docs.sympy.org/dev/index.html" target="_blank">SymPy</a></li> | ||
| <li><a href="http://matplotlib.sourceforge.net/" target="_blank">Matplotlib</a></li> | ||
| <li><a href="http://pandas.pydata.org/pandas-docs/stable/" target="_blank">pandas</a></li> |
There was a problem hiding this comment.
as I wrote in #4011 I would prefer this to bee a loop over [(name,url), ....] to be easier to patch for kernels like julia/ruby.
The divider is a nice limitation of what is IPython specific and can be hard coded. And what should be language dependent.
There was a problem hiding this comment.
you mean you want me to remove all of those and replace them with a just a place holder, and have some javascript fill in those links into that place holder?
There was a problem hiding this comment.
you mean you want me to remove all of those and replace them with a just a place holder, and have some javascript fill in those links into that place holder?
Or Jinja, I don't know. What do you think ?
There was a problem hiding this comment.
Well, I suppose that's just a question of whether we want this to
be done on notebook load server side (jinja) or dynamically
(javascript). I'm thinking javascript will be nicer, and that way
maybe packages could have methods that hook into that system and
register themselves in the menu.
What do you (and others) think?
There was a problem hiding this comment.
Let's wait on that - when we are start to think about integrating notebook
documentation for third party libraries we will have to tackle all of that.
On Wed, Aug 14, 2013 at 2:42 PM, Paul Ivanov notifications@github.comwrote:
In IPython/html/templates/notebook.html:
<li><a href="http://docs.sympy.org/dev/index.html" target="_blank">SymPy</a></li>
<li><a href="http://matplotlib.sourceforge.net/" target="_blank">Matplotlib</a></li><li><a href="http://pandas.pydata.org/pandas-docs/stable/" target="_blank">pandas</a></li>Well, I suppose that's just a question of whether we want this to be done
on notebook load server side (jinja) or dynamically (javascript). I'm
thinking javascript will be nicer, and that way maybe packages could have
methods that hook into that system and register themselves in the menu.
What do you (and others) think?—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4022/files#r5777308
.
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
There was a problem hiding this comment.
It is true that at some point we will be able to start many kernels from a single notebook...
So let's leave forget about config for now.
|
1 small comment, an relaunched travis build on 2.6 which failed for unrelated reason. |
|
+1 to merge. |
DOC: fix links to matplotlib, notebook docs
|
I like pushing that green button :) thanks for the review @Carreau and @ellisonbg! |
I've added a link to pandas, made all matplotlib links point to matplotlib.org, and fixed a link in the notebook help menu to point to our new notebook.html, now that htmlnotebook.html is a redirect. Whoever ends up merging this PR should backport it to 1.x.
DOC: fix links to matplotlib, notebook docs
I've added a link to pandas, made all matplotlib links point to
matplotlib.org, and fixed a link in the notebook help menu to point to our new
notebook.html, now that htmlnotebook.html is a redirect.
Whoever ends up merging this PR should backport it to 1.x.