add files with a separate add call in backport_pr
#4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`git commit [filename]` will fail if the filename is not already tracked. /cc @ivanov
| commit = Popen(['git', 'commit', '-m', msg] + filenames) | ||
| add = Popen(['git', 'add'] + filenames) | ||
| add.wait() | ||
| if add.returncode: |
There was a problem hiding this comment.
I think we can use call(), which returns the return code, rather than creating a Popen and wait()ing on it.
There was a problem hiding this comment.
yup, I am using check_call elsewhere in the function, and should be using it here as well. Just an artifact of copy/pasting the wrong block.
in backport_pr
|
Great, merging. |
takluyver
added a commit
that referenced
this pull request
Aug 29, 2013
add files with a separate `add` call in backport_pr
minrk
added a commit
that referenced
this pull request
Sep 4, 2013
`git commit [filename]` will fail if the filename is not already tracked. /cc @ivanov
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
add files with a separate `add` call in backport_pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git commit [filename]will fail if the filename is not already tracked./cc @ivanov