various issues in markdown and rst templates #4174
Conversation
- remote prompts from output - add missing HTML block - remove double-wrapping of latex - use plain-markdown indentation for code blocks (could use GFM '` ` `python') closes ipython#4024 candidate for backport to 1.1
|
I guess nobody has ever actually tried to use rst or markdown output from nbconvert - they are all kinds of wrong. I will try to limit the scope of this PR before I get carried away, but I wouldn't recommend that anyone use 1.x for markdown or rst output ever. |
|
This is no longer that minor. The markdown template assumed that output was extracted, but it wasn't. I went with turning on figure-extraction, but I can also do inline HTML images if people would prefer. @ellisonbg? |
|
Hmm, I am not sure I have strong feelins either way. In the long run we On Thu, Sep 5, 2013 at 6:32 PM, Min RK notifications@github.com wrote:
Brian E. Granger |
|
|
||
| def path2url(path): | ||
| """Turn a file path into a URL""" | ||
| parts = os.path.split(path) |
There was a problem hiding this comment.
I don't think os.path.split() splits all parts of a path name, just directory name and basename. Should this be path.split(os.sep)?
There was a problem hiding this comment.
Yes, of course. I always make this mistake, thanks.
|
Simplest is extracting files, which is what it does now. Making it configurable isn't difficult, and makes sense for both markdown and HTML, but we can look into that later. |
use split-files for embedded images add path2url
various issues in markdown and rst templates - remove prompts from default output - add missing HTML block - remove double-wrapping of latex - use plain-markdown indentation for code blocks (could use GFM ``` ` ` `python```) - images didn't work in either one at all - markdown extracts output closes #4024
- remove prompts from default output - add missing HTML block - remove double-wrapping of latex - use plain-markdown indentation for code blocks (could use GFM ``` ` ` `python```) - images didn't work in either one at all - markdown extracts output closes #4024 candidate for backport to 1.1
* commit 'rel-1.1.0-3-gb8b89ca': (66 commits) Backport PR ipython#4209: Magic doc fixes Backport PR ipython#4204: remove some extraneous print statements from IPython.parallel back to dev release 1.1.0 don't upload to GitHub in release script 1.1 backport stats Backport PR ipython#4188: Allow user_ns trait to be None Backport PR ipython#4189: always fire LOCAL_IPS.extend(PUBLIC_IPS) Backport PR ipython#4174: various issues in markdown and rst templates Backport PR ipython#4181: nbconvert: Fix, sphinx template not removing new lines from headers Backport PR ipython#4043: don't 'restore_bytes' in from_JSON Backport PR ipython#4178: add missing data_javascript Backport PR ipython#4136: catch javascript errors in any output Backport PR ipython#4163: Fix for incorrect default encoding on Windows. Backport PR ipython#4171: add nbconvert config file when creating profiles Backport PR ipython#4159: don't split `.cell` and `div.cell` CSS Backport PR ipython#4158: generate choices for `--gui` configurable from real mapping Backport PR ipython#4143: update example custom.js Backport PR ipython#4144: help_end transformer shouldn't pick up ? in multiline string Backport PR ipython#4104: Add way to install MathJax to a particular profile ...
* commit 'rel-1.1.0-7-gf5891e9': (70 commits) Backport PR ipython#4346: getpass() on Windows & Python 2 needs bytes prompt Backport PR ipython#4336: use simple replacement rather than string formatting in format_kernel_cmd Backport PR ipython#4316: underscore missing on notebook_p4 Backport PR ipython#4257: fix unicode argv parsing Backport PR ipython#4209: Magic doc fixes Backport PR ipython#4204: remove some extraneous print statements from IPython.parallel back to dev release 1.1.0 don't upload to GitHub in release script 1.1 backport stats Backport PR ipython#4188: Allow user_ns trait to be None Backport PR ipython#4189: always fire LOCAL_IPS.extend(PUBLIC_IPS) Backport PR ipython#4174: various issues in markdown and rst templates Backport PR ipython#4181: nbconvert: Fix, sphinx template not removing new lines from headers Backport PR ipython#4043: don't 'restore_bytes' in from_JSON Backport PR ipython#4178: add missing data_javascript Backport PR ipython#4136: catch javascript errors in any output Backport PR ipython#4163: Fix for incorrect default encoding on Windows. Backport PR ipython#4171: add nbconvert config file when creating profiles Backport PR ipython#4159: don't split `.cell` and `div.cell` CSS ...
various issues in markdown and rst templates - remove prompts from default output - add missing HTML block - remove double-wrapping of latex - use plain-markdown indentation for code blocks (could use GFM ``` ` ` `python```) - images didn't work in either one at all - markdown extracts output closes ipython#4024
closes #4024
candidate for backport to 1.1