generate choices for --gui configurable from real mapping
#4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo prevented `--gui tk` from working, even though it is supported. Should prevent similar bugs in the future. closes ipython#4156 should be backported to 1.1
|
|
||
| #----------------------------------------------------------------------------- | ||
| # Aliases and Flags | ||
| #----------------------------------------------------------------------------- | ||
|
|
||
| gui_keys = tuple(sorted([ key for key in guis if key is not None ])) |
There was a problem hiding this comment.
This is fine, but you can also use filter, as in gui_keys = tuple(sorted(filter(None, guis))) if the key for key in guis... seems to verbose.
|
Shall we merge? This looks good to me. |
minrk
added a commit
that referenced
this pull request
Sep 4, 2013
generate choices for `--gui` configurable from real mapping typo prevented --gui tk from working, even though it is supported. Should prevent similar bugs in the future. closes #4156
minrk
added a commit
that referenced
this pull request
Sep 4, 2013
…l mapping typo prevented `--gui tk` from working, even though it is supported. Should prevent similar bugs in the future. closes #4156 should be backported to 1.1
yarikoptic
added a commit
to yarikoptic/ipython
that referenced
this pull request
May 2, 2014
* commit 'rel-1.1.0-3-gb8b89ca': (66 commits) Backport PR ipython#4209: Magic doc fixes Backport PR ipython#4204: remove some extraneous print statements from IPython.parallel back to dev release 1.1.0 don't upload to GitHub in release script 1.1 backport stats Backport PR ipython#4188: Allow user_ns trait to be None Backport PR ipython#4189: always fire LOCAL_IPS.extend(PUBLIC_IPS) Backport PR ipython#4174: various issues in markdown and rst templates Backport PR ipython#4181: nbconvert: Fix, sphinx template not removing new lines from headers Backport PR ipython#4043: don't 'restore_bytes' in from_JSON Backport PR ipython#4178: add missing data_javascript Backport PR ipython#4136: catch javascript errors in any output Backport PR ipython#4163: Fix for incorrect default encoding on Windows. Backport PR ipython#4171: add nbconvert config file when creating profiles Backport PR ipython#4159: don't split `.cell` and `div.cell` CSS Backport PR ipython#4158: generate choices for `--gui` configurable from real mapping Backport PR ipython#4143: update example custom.js Backport PR ipython#4144: help_end transformer shouldn't pick up ? in multiline string Backport PR ipython#4104: Add way to install MathJax to a particular profile ...
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
generate choices for `--gui` configurable from real mapping typo prevented --gui tk from working, even though it is supported. Should prevent similar bugs in the future. closes ipython#4156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typo prevented
--gui tkfrom working, even though it is supported. Shouldprevent similar bugs in the future.
closes #4156
should be backported to 1.1