-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow edit mode up arrow to continue past index == 0 #5261
Conversation
The code looks good and I have confirmed the fix. Merging. |
Don't allow edit mode up arrow to continue past index == 0
This shouldn't have been merged, there are more serious issues at work that should be addressed. |
I know we may have other bugs to track down, but this does fix the issue. On Mon, Mar 3, 2014 at 11:38 AM, Min RK notifications@github.com wrote:
Brian E. Granger |
Looking at this further, I do see an issue with how we call |
We were looking over this fix and the various other similar bugs still in master, and this seemed like treating a symptom rather than addressing the root cause. Based on the behavior, it seems like there is a more severe underlying issue, and little patches as individual symptoms are noticed are not helping address it. |
We think the other issues showing up in master are from situations where On Mon, Mar 3, 2014 at 3:04 PM, Min RK notifications@github.com wrote:
Brian E. Granger |
I would open separate issues for them. It helps us to track them - even if On Mon, Mar 3, 2014 at 3:57 PM, Min RK notifications@github.com wrote:
Brian E. Granger |
Don't allow edit mode up arrow to continue past index == 0
closes #5259