Check process existence when listing nbserver processes #6099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. 👍 |
| try: | ||
| os.unlink(file) | ||
| except OSError: | ||
| pass # TODO: This should warn or log or something |
There was a problem hiding this comment.
do you want to actually log something here, or should we merge as is ?
|
Looking forward to using the new nbopen and related functionality!
Just a note that the |
minrk
added a commit
that referenced
this pull request
Jul 20, 2014
Check process existence when listing nbserver processes
|
Weren't there some |
|
Whenever it's clear what warning/logging it should do, anyone can add that later. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Check process existence when listing nbserver processes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing nbopen, I realised that listing the available nbservers gave me info for a dozen servers that had died without cleaning up their info. This implements a simple check that a process with the given pid exists. This isn't perfect, because another process could be reusing the same pid, but the chances of that are fairly low, and it can't give a false negative, as far as I know.
I haven't tried to implement a .NET version of check_pid for the
_process_climodule. The ctypes version for Windows is taken from code inIPython.parallel- this is simplified to use the new utility function.